fix: enforce admin auth inside treasury mutations - #221
Merged
N-thnI merged 1 commit intoAug 22, 2026
Merged
Conversation
Schedule, execute, and snapshot paths now require an authenticated treasury admin so later ControlPlane wiring cannot omit the check. Co-authored-by: Cursor <cursoragent@cursor.com>
N-thnI
approved these changes
Aug 22, 2026
7 tasks
Contributor
|
Merged — thanks for the contribution! If you've got a moment, a rating on GrantFox helps the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add caller authentication inside
engine-core/src/treasury.rsitself, so fund outflows and snapshot writes cannot be invoked without an authorized admin even after they are wired into ControlPlane.Related Issue
Closes #204
Changes Made
initnow records a treasury admin (TR_ADMIN)schedule_outflow,execute_outflow, andrecord_snapshottake acallerand callrequire_auth()plus an admin membership checkrequire_authmissing) and unauthorized (non-admin) rejection for each functioncallerand cannot bypass this check; reservedTR_ADMINsoupdate_paramcannot overwrite itTesting Performed
cargo test --manifest-path engine-core/Cargo.toml --lib— 92 passed)Checklist
feat/,fix/,chore/, etc.)Closes #204reference is present above (linking this PR to the issue)Made with Cursor